Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

fix: share 'LuIntentEditor' widget across recognizers#4350

Merged
cwhitten merged 4 commits intomicrosoft:mainfrom
yeze322:uiwidgets/recognizer
Oct 12, 2020
Merged

fix: share 'LuIntentEditor' widget across recognizers#4350
cwhitten merged 4 commits intomicrosoft:mainfrom
yeze322:uiwidgets/recognizer

Conversation

@yeze322
Copy link
Contributor

@yeze322 yeze322 commented Oct 12, 2020 •
edited
Loading

Description

closes #4167

According to design, the <LuIntentEditor /> widget will be applied to not only LuisRecognizer and CrossTrainedRecognizer but the PVARecognizer. Previously, sharing widgets between recognizer uischemas was implemented in a hack way, in which a widget is copied manually from one recognizer to another.

This PR solves the problem by registering and sharing widgets via the widgets object in the PluginConfig as Flow widgets did. All recognizer-related widgets will be put under the widgets.recognizer filed of PluginConfig.

Now, the definition of PluginConfig look like this:

export interface PluginConfig {
  uiSchema?: UISchema;
  widgets?: UIWidgets;
}

export type UIWidgets = {
  flow?: FlowEditorWidgetMap;
  recognizer?: { [name: string]: FieldWidget };
};

In PVA scenario, PVARecognizer can consume the widget LuIntentEditor as below @tonyanziano.

{
  "Microsoft.PVARecgonizer": {
    ...,
    "intentEditor": "LuIntentEditor"
  }
}

PVA Remaining problems:

  • Need a solution to retrive the recognizer's .lu file via recognizer json.

Task Item

Screenshots

Here is the LuIntentEditor
image

@yeze322 yeze322 marked this pull request as ready for review October 12, 2020 11:37
@coveralls
Copy link

coveralls commented Oct 12, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.004%) to 56.026% when pulling 4aa9cbe on yeze322:uiwidgets/recognizer into d5fdd02 on microsoft:main.

@cwhitten cwhitten merged commit 9e98dfc into microsoft:main Oct 12, 2020
tonyanziano pushed a commit that referenced this pull request Oct 13, 2020
@yeze322 @cwhitten @tonyanziano
fix: share 'LuIntentEditor' widget across recognizers (#4350)
e1ca598 
* put 'flowWidgets' under 'widgets'

* share 'LuIntentEditor' via widgets

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@yeze322 @cwhitten
fix: share 'LuIntentEditor' widget across recognizers (microsoft#4350)
f4fd822 
* put 'flowWidgets' under 'widgets'

* share 'LuIntentEditor' via widgets

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@beyackle beyackle Awaiting requested review from beyackle

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@hatpick hatpick Awaiting requested review from hatpick

@srinaath srinaath Awaiting requested review from srinaath

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

1 more reviewer

@cwhitten cwhitten cwhitten approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Align UI Widget's area with UI Schema

3 participants

@yeze322 @coveralls @cwhitten